opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

feat(otelgin): add support for recording panics

Open asecondo opened this issue 1 year ago • 3 comments
trafficstars

Implements as described in #5088

asecondo avatar Feb 14 '24 03:02 asecondo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.1%. Comparing base (a111e3e) to head (bb56d55).

:exclamation: Current head bb56d55 differs from pull request most recent head 0b7fca7. Consider uploading reports for the commit 0b7fca7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5090     +/-   ##
=======================================
- Coverage   61.2%   61.1%   -0.2%     
=======================================
  Files        185     185             
  Lines      11207   13786   +2579     
=======================================
+ Hits        6865    8428   +1563     
- Misses      4142    5162   +1020     
+ Partials     200     196      -4     
Files Coverage Δ
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 84.2% <100.0%> (+3.9%) :arrow_up:
...ntation/github.com/gin-gonic/gin/otelgin/option.go 100.0% <100.0%> (ø)

... and 183 files with indirect coverage changes

codecov[bot] avatar Feb 14 '24 08:02 codecov[bot]

Hello, I'm also using otelgin and would very much like this issue to be merged. Can we have a little update on this? Thanks a lot!

mxpetit avatar Apr 15 '24 14:04 mxpetit

Hello, I'm also using otelgin and would very much like this issue to be merged. Can we have a little update on this? Thanks a lot!

hey @mxpetit - from the discussion in this thread, my current plan is to wait for #5092 to complete, likely make a few changes on top of that, then look to get this merged.

asecondo avatar Apr 17 '24 03:04 asecondo

I think the handling of this PR should refer to the method of this PR: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6366

flc1125 avatar Nov 26 '24 05:11 flc1125

I added a comment here: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5088#issuecomment-2499904424

@asecondo, I am changing this PR to draft as it is not in a mergeable state there are no approvals.

pellared avatar Nov 26 '24 08:11 pellared