Robert Pająk

Results 1097 comments of Robert Pająk

Maybe it would be good to discuss under https://github.com/open-telemetry/opentelemetry-specification? For security reasons the [`db.statement` was made conditional](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#call-level-attributes). Maybe we could use a similar approach for [http sem conv](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md)? _In general...

This was requested a few times in https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation. Usually people are asking for adding the SQL statement tag for all queries/statements.

> It is not recommended to attempt any client-side parsing of db.statement just to get these properties, they should only be used if the library being instrumented already provides them....

For some libraries (e.g. ORM) it would be fine. But with SqlClient (which is very low level) I do not think it is possible without parsing the statements which is...

Can you please run [benchstat](https://pkg.go.dev/golang.org/x/perf/cmd/benchstat) and add the result to the description to see what is the performance overhead?

Please fix the lint errors (you can ignore the errors as the returned error is always nil).

> This branch is out-of-date with the base branch @santileira can you please update the branch (we cannot do it ourselves as edits are not allowed for us on your...

@MrAlias, do you think it makes sense to add `MinSeverityProcessor` as an example? I feel uncertain as I would personally would prefer to have it as part of the SDK....

@MrAlias, I plan to update the example to https://github.com/open-telemetry/opentelemetry-go/pull/5543#issuecomment-2194334650. Let me know if you have a better example proposal if you have any other suggestion.

Ready for another round of reviews after rework.