Peter Dillinger

Results 50 comments of Peter Dillinger

> for isolation What sort of isolation?

CI seems to indicate broken new download links

Also, use `unreleased_history/add.sh` to add a release note. At this point, the user should care that they have the option to override this new function to make some file metadata...

It's a big mess. It's not clear at all what it means to override a function in Env but to provide different functionality for the equivalent function in FileSystem. IMHO...

@hx235 We can continue the discussion about EnforceReadOpts here. With regard to calling UsedIO from lower-level IO functions, I worry a bit about the fan-out to various implementations and functions,...

We don't normally promise [forward compatibility](https://en.wikipedia.org/wiki/Forward_compatibility), with default options, beyond about a 6 month horizon. However, this looks to be a serious bug in persisting `ValueType:: kTypeMaxValid` which is subject...

> I think it should be ok to use 9.7.3. Though you won't be able to downgrade to older versions due to the issue you described. Though if I understand...

The `PrefetchIndexAndFilterBlocks` function is accessing a static const unordered_map. That suggests either memory corruption or that this occurs while some other thread is running static destructors, perhaps in the process...

This has been quietly outstanding for a while. Just requesting you get to it when you pretty easily can.