Peter Dillinger

Results 50 comments of Peter Dillinger

> By the way, I have a refactoring in progress that should completely solve this issue I should say my solution also depends on the table reader staying alive, but...

Sorry for missing the earlier discussion. I have some issues with this change: * Destructors should involve blocking operations as minimally as possible, as they might be run when an...

> > * Destructors should involve blocking operations as minimally as possible > We could try that. I'd be slightly worried about users of `delete db;` who were previously getting...

> @pdillinger Apart from the comments above, generally speaking - does this seem in the right track for what you had in mind? Yes, generally in the right direction. Obviously...

This pull request has picked up a bunch of other changes, making it hard to see what is only the configuration validation part. I guess I can do `git diff...

going with https://github.com/facebook/rocksdb/pull/12652 instead

Diff abandoned

I'd hate for everyone to pay a small tax for this feature, and a sizable one for those actually using it. Can we re-work this so that the inner loop...

Obsolete by #13017

The API and functionality is not yet complete for the filtering you want, but the KeySegmentsExtractor API is intended to be complete. > Specifically, the segments cannot overlap part means...