Peter Dillinger
Peter Dillinger
Summary: C++20 deprecates [=] capturing 'this' (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0806r2.html) but the recommended alternative [=,this] is not standards-legal prior to C++20 (though it is widely accepted *with warning*). For portability (and readability), style...
Summary: ... so that cache keys can be derived from DB manifest data before reading the file from storage--so that every part of the file can potentially go in a...
From https://github.com/facebook/rocksdb/pull/8261#issuecomment-832247624: Unfortunately, there is at least one more bug in ClockCache that shows up in the crash test: ***db_stress: cache/clock_cache.cc:486: bool rocksdb::{anonymous}::ClockCacheShard::Unref(rocksdb::{anonymous}::CacheHandle*, bool, rocksdb::{anonymous}::CleanupContext*): Assertion `CountRefs(flags) > 0' failed.***...
Summary: The info LOG file does not currently give any direct information about the existence of old, live snapshots, nor how to estimate wall time from a sequence number within...
Apply this patch to expand SetOptions testing in stress test and amplify bad behavior: ``` diff --git a/db_stress_tool/db_stress_test_base.cc b/db_stress_tool/db_stress_test_base.cc index 0c8b7ee08..b1200c3e5 100644 --- a/db_stress_tool/db_stress_test_base.cc +++ b/db_stress_tool/db_stress_test_base.cc @@ -254,6 +254,11 @@...
We had to patch 7.4 again for a serious bug. This issue tracks creating new Java packages
Summary: We have a lot of confusing code because of mixed, sometimes completely opposite uses of of the term "raw block" or "raw contents", sometimes within the same source file....
https://github.com/facebook/rocksdb/blob/3653029dda238692564773552c55cc29fea10310/tools/db_bench_tool.cc#L1548 https://github.com/facebook/rocksdb/blob/3653029dda238692564773552c55cc29fea10310/tools/benchmark.sh#L521 https://github.com/facebook/rocksdb/blob/3653029dda238692564773552c55cc29fea10310/include/rocksdb/db.h#L586 https://github.com/facebook/rocksdb/wiki/Performance-Benchmarks#test-3-multi-random-read-benchmarksh-multireadrandom Fortunately, regression_test.sh does use batched MultiGet: https://github.com/facebook/rocksdb/blob/3653029dda238692564773552c55cc29fea10310/tools/regression_test.sh#L249
Summary: RocksDB allows Comparators to treat keys with different byte contents as equal, if that's appropriate for the application, but that makes the comparator incompatible with a number of hashing-based...
Summary: ... by allocating in increments (1MiB) smaller than the typical smallest huge page size of 2MiB. Fixes #12351 Test Plan: ``` sudo bash -c 'echo "always" > /sys/kernel/mm/transparent_hugepage/enabled' ```...