rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Support GetFileSize API in FSRandomAccessFile

Open xingbowang opened this issue 6 months ago • 8 comments

Summary:

This change is used to address this issue https://github.com/facebook/rocksdb/issues/13619 It supports GetFileSize API in FSRandomAccessFile. This allows ReadFooterFromFile to quickly get the file size for file size validation.

Test Plan: make check

Reviewers: Peter Dillinger

Subscribers:

Tasks:

Tags:

xingbowang avatar Jun 06 '25 22:06 xingbowang

@xingbowang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 06 '25 22:06 facebook-github-bot

Also, use unreleased_history/add.sh to add a release note. At this point, the user should care that they have the option to override this new function to make some file metadata queries more efficient. And we could say that this function might be required in the future.

pdillinger avatar Jun 10 '25 15:06 pdillinger

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 16 '25 20:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 16 '25 20:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 17 '25 18:06 facebook-github-bot

@xingbowang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 17 '25 22:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 17 '25 23:06 facebook-github-bot

@xingbowang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 17 '25 23:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 18 '25 21:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 18 '25 22:06 facebook-github-bot

@xingbowang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 18 '25 23:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 19 '25 13:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 19 '25 13:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 20 '25 17:06 facebook-github-bot

@xingbowang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 20 '25 17:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 23 '25 16:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 23 '25 16:06 facebook-github-bot

@xingbowang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 23 '25 19:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 23 '25 19:06 facebook-github-bot

@xingbowang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 23 '25 21:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 30 '25 16:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 30 '25 16:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 30 '25 16:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 30 '25 17:06 facebook-github-bot

@xingbowang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 30 '25 17:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 30 '25 19:06 facebook-github-bot

@xingbowang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 30 '25 19:06 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jul 03 '25 13:07 facebook-github-bot

@xingbowang has imported this pull request. If you are a Meta employee, you can view this in D76168033.

facebook-github-bot avatar Jul 03 '25 15:07 facebook-github-bot

@xingbowang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jul 08 '25 16:07 facebook-github-bot