facebook
Update compression libraries to latest releases
See Makefile for actual changes:
- ZLIB remains the same
- BZIP2 remains the same
- SNAPPY is a minor update
- LZ4 is a significant update with multithreaded/multicore compression https://github.com/lz4/lz4/releases/tag/v1.10.0
- ZSTD is a significant update RocksDB is called out as benefiting in particular from the performance improvements herein https://github.com/facebook/zstd/releases/tag/v1.5.7
Thanks @pdillinger I've asked @adamretter to update the S3 as I don't have those permissions
@pdillinger @mszeszko-meta this one is now good to go go to both main and 10.4.fb branches I think.
@adamretter it looks like RocksDB native library cannot be found or loaded (build-linux-java). I think we should fix it before merging this change.
@adamretter, separately, there are well over 100 warnings about deprecated features, syntax, enums in build-linux-java here. I think we might be reaching a good critical mass to tackle this in a followup PR. What do you think?
it looks like RocksDB native library cannot be found or loaded (build-linux-java). I think we should fix it before merging this change.
@mszeszko-meta That's strange, all was passing before. I have restarted the failed jobs.
separately, there are well over 100 warnings about deprecated features, syntax, enums in build-linux-java here. I think we might be reaching a good critical mass to tackle this in a followup PR. What do you think?
These come about because we have test cases for the deprecated functions. What do you suggest? How long should deprecated functions stay around for before we remove them?
it looks like RocksDB native library cannot be found or loaded (build-linux-java). I think we should fix it before merging this change.
@mszeszko-meta That's strange, all was passing before. I have restarted the failed jobs.
separately, there are well over 100 warnings about deprecated features, syntax, enums in build-linux-java here. I think we might be reaching a good critical mass to tackle this in a followup PR. What do you think?
These come about because we have test cases for the deprecated functions. What do you suggest? How long should deprecated functions stay around for before we remove them?
@adamretter, looks like java build is still failing. Let's get that resolved first. I'll get back to you on the deprecation topic afterwards.
@mszeszko-meta Just to update you, that we have been investigating this. It is very mysterious, as nothing we can see in this PR should have caused the issue that is suddenly showing in CI. Also it is strange that it is passing on macOS, but not Linux. We are continuing to investigate...
@mszeszko-meta Some good news finally... we have managed to reproduce the issue locally and are investigating a fix.
@mszeszko-meta has imported this pull request. If you are a Meta employee, you can view this in D77877295.
@adamretter , is this commit a blocker for 10.4 release? In other words, does it require back porting?
@mszeszko-meta merged this pull request in facebook/rocksdb@805ac7c887bbebd7e6124bbc7e8d0803aeed8f07.