Paul Cody Johnston

Results 84 comments of Paul Cody Johnston

Hit this error as well. Could not find a unit test for the many-to-many case.

Right. Currently grpc-web endpoint responses can't be cached by a service worker without something like this. I'm not exactly expecting this to be merged at this time, I just put...

Part of the problem is that Closure tools itself has no logo, so there's really no compositional guidance there.

Oh sorry, I always thought that was for google tech blogs, not Closure in particular. My apologies.

Looking at that I'd say Closure logo is due for an upgrade, just like the Google logo itself has evolved over the years. Needs more overall padding, more negative space,...

Nice, I am a sucker for graph diagrams.

Note: I wrote a special repository rule some time ago to get over this issue. It may be a workaround until this gets easier. https://github.com/stackb/rules_proto/blob/master/closure/deps.bzl#L8-L33

I like the idea of incorporating clang-format. I also like, for example, how golang is stylistically rigid so you don't have to think about it. Similar idea with clang-format.

Any progress on this? I was thinking unpack @com_google_javascript_closure_compiler_externs//:externs.zip and write a BUILD file. Probably as a custom repository rule. Simpler approach? But this does not cover contrib/externs, so maybe...

I'm not following regarding the influence of dead-code elimination (but I'm glad you have a better clue than me ): It's well-known that that closure library generates thousands of errors/warnings...