Paul Cody
Paul Cody
@gravypod I think the code looks good (I didn't see any changes since we paired on it, is there a particular spot I should look at?). I think it is...
@ianoc I think maybe you're misunderstanding how it works. There is no need to fetch go externally, the toolchain is already there via rules_go, which is an absolute prerequisite for...
I'll rebase and freshen this branch up.
@ianoc A few comments: - Removing golang from `rules_docker` is IMHO out-of-scope, the effort is too large, without a clear reason. If you really want containers with bazel and not...
To restate the problem: > Note @ianoc this is not a response to your last comments, I was writing it independent of that. - The puller is used by `pull.bzl`...
@johnynek nice to hear from you, it's been a while since I sat next to you at bazelcon like 4 or 5 years ago! It is a misunderstanding that this...
@sluongng Yes thanks for making it more clear how `go_repository` rule works. Note this is also how the [proto_repository](https://github.com/stackb/rules_proto#proto_repository) works (https://github.com/stackb/rules_proto/blob/master/rules/private/proto_repository_tools.bzl). I'd say if we really want to feature-flag it,...
Writing the header proto size, then the message, then the content sounds pretty reasonable to me. For inspiration, similar code is in: https://github.com/kythe/kythe/blob/master/kythe/go/platform/delimited/delimited.go
I think it's cool that you put this together, but I'm a little wary of this as-is for a couple of reasons: 1. It's a bit telling that I've never...
I don't see how `--interval = 5s --timeout = 10s --retries = 3 CMD curl -sS 127.0.0.1` could possibly be confusing to any user wanting to use this, because that's...