rules_closure icon indicating copy to clipboard operation
rules_closure copied to clipboard

Published 20 hours ago • verified publisher icon bazelbuild

Create rules for contrib/externs

Open hochhaus opened this issue 8 years ago • 6 comments

Working with this project would be a bit simpler if we included contrib/externs in the set of external dependencies that are installed automatically.

hochhaus avatar May 08 '16 16:05 hochhaus

Doesn't it do that already?

jart avatar May 08 '16 18:05 jart

Maybe, but I couldn't find the contrib externs. How would I reference contrib/externs/chrome_extensions.js?

hochhaus avatar May 08 '16 18:05 hochhaus

That's available on maven in separate jar that zips them all together. It's currently not available in Closure Rules. We could certainly add it and make it available under certain build rules.

jart avatar May 08 '16 19:05 jart

Any progress on this? I was thinking unpack @com_google_javascript_closure_compiler_externs//:externs.zip and write a BUILD file. Probably as a custom repository rule. Simpler approach? But this does not cover contrib/externs, so maybe unpack the closure_compiler.jar and use that.

pcj avatar Feb 08 '17 03:02 pcj

I would recommend implementing the workaround you described for the time being. Defining a good public build API for all these externs is probably not something I have the cycles to take on at this moment.

jart avatar Feb 08 '17 07:02 jart

@pcj Sorry but I have not done any work on this yet.

hochhaus avatar Feb 08 '17 22:02 hochhaus