Paul Cody Johnston comments

Results 89 comments of


Paul Cody Johnston

Move most of gazelle main package into a subpackage

I suspect the age of the PR will require someone making sure all the changes that have occurred in cmd/gazelle since July 2022 are faithfully propagated to this one. I'd...

Move most of gazelle main package into a subpackage

FWIW I'm +1 on accepting this. @achew22 I believe your question was answered previously, do you have any remaining concerns?

#gazelle:proto file” directive isn’t usable unless option go_package is explicitly set in each proto_library

I tend to be using https://github.com/stackb/rules_proto for gazelle proto support, which does use the `language/proto` and `proto_library` generation, but does not use the `go_proto_library` rule. I'm not saying the OP...

#gazelle:proto file” directive isn’t usable unless option go_package is explicitly set in each proto_library

That sounds about right to me. I'm not an ex-googler so I don't know how things are inside G, but I think I saw some hint somewhere from @adonovan that...

buildifier(feature): .buildifier.json config file

@JayBazuzi that sounds fine to me. Regarding the JSON comments, I considered using a YAML config file but there is no yaml library in the stdlib and didn't want to...

buildifier(feature): .buildifier.json config file

Updated and squashed to https://github.com/bazelbuild/buildtools/pull/1080/commits/ee3f889a752c9bd6e3c2e136baa4788ff2e51eee

proto_compiled_sources outputs to the wrong directory

@paiyar thanks for the notification. Let me take a closer look.

proto_compiled_sources outputs to the wrong directory

@paiyar agree let's revert that for now. I'll prepare a similar PR that you have on your branch.

proto_compiled_sources outputs to the wrong directory

Reverted in https://github.com/stackb/rules_proto/pull/315