Pavel Kalinnikov
Pavel Kalinnikov
These stats are only printed in text to the logs. There is a queue size metric introduced in 5d51ab34 which properly exports these stats to monitoring. The exported graphs allow...
Release note: None
Some of the code is unnecessarily complex because previously it tried to accommodate both `Log` and `Map` trees. After maps removal [#2284] it makes sense to minimize this code, so...
The are conditions under which SQL-specific errors slip all the way to the client. Example of what this can cause: #2340, reproduced in #2342. We should either allow this in...
Trillian `logerver` doesn't always wrap the returned errors into [status](https://pkg.go.dev/google.golang.org/grpc/status). GRPC [automatically](https://github.com/grpc/grpc-go/blob/754ee590a4f386d0910d887f3b8776354042260b/interceptor.go#L52) wraps non-status errors into a status with `code.Unknown` and message `err.Error()`. This causes a situation where a `context.DeadlineExceeded`...
Scripts in [integration/](https://github.com/google/trillian/tree/5abce90b597eaadd29cdbf83042f9ec9255b7f7c/integration) are hard to maintain, and contain bugs. For example, after running `run_integration.sh` there are dangling Trillian servers. Also, a developer needs to install tooling that exactly corresponds...
`LogOperation` and its co-types are poorly designed: - [ ] They are meant to be stateless, but in reality there are caches in various places like `SequencerManager` (see the list...
#2341 See CI logs for the "presubmit" checks around `client/log_client_test.go/TestWaitForInclusion`.
Fixes #81227 Release note: upgrade grpc from v1.46.0 to v.1.47.0 which fixes a subtle bug causing panic on a nil pointer.
The amount of boilerplate to run a sequence of commands in a `datadriven` test is excessive. For example, [here](https://github.com/etcd-io/raft/blob/026484c68b7bc59cd208e216d35e1ff747d24d9c/testdata/replicate_pause.txt#L10-L55) is a typical script. This is visually unsatisfying (the amount of...