trillian icon indicating copy to clipboard operation
trillian copied to clipboard

Reduce code complexity related to maps

Open pav-kv opened this issue 3 years ago • 2 comments

Some of the code is unnecessarily complex because previously it tried to accommodate both Log and Map trees. After maps removal [#2284] it makes sense to minimize this code, so that it's log-specific. If anything related to maps reappears in the repo, it still makes sense to keep the code decoupled to a greater degree than previously.

Examples:

  • [ ] storage/cache can be removed completely, or significantly simplified.
  • [x] The NodeID&co types should be made log-specific. It likely needs to be replaced by a simple compact.NodeID, whereas for maps the NodeID2 type is more suitable.
  • [ ] The LogStorage/TreeStorage/MapStorage interfaces can be reduced.

pav-kv avatar Mar 01 '21 19:03 pav-kv

@pavelkalinnikov is the checklist in the original comment still accurately tracking the remaining work on this?

mhutchinson avatar May 26 '22 11:05 mhutchinson

Yes, it still looks relevant.

pav-kv avatar Jun 10 '22 12:06 pav-kv