trillian icon indicating copy to clipboard operation
trillian copied to clipboard

Reproduce issue 2341

Open pav-kv opened this issue 5 years ago • 2 comments

#2341 See CI logs for the "presubmit" checks around client/log_client_test.go/TestWaitForInclusion.

pav-kv avatar Feb 08 '21 13:02 pav-kv

Codecov Report

Merging #2342 (78725ef) into master (de9ed73) will decrease coverage by 0.05%. The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2342      +/-   ##
==========================================
- Coverage   65.47%   65.42%   -0.06%     
==========================================
  Files         116      116              
  Lines        8822     8829       +7     
==========================================
  Hits         5776     5776              
- Misses       2386     2391       +5     
- Partials      660      662       +2     
Impacted Files Coverage Δ
server/log_rpc_server.go 82.27% <14.28%> (-1.10%) :arrow_down:
client/log_verifier.go 71.73% <0.00%> (-2.18%) :arrow_down:
client/log_client.go 68.60% <0.00%> (-1.17%) :arrow_down:
log/operation_manager.go 88.35% <0.00%> (+1.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de9ed73...78725ef. Read the comment docs.

codecov[bot] avatar Feb 08 '21 13:02 codecov[bot]

$ go test -alsologtostderr -run TestWaitForInclusion
...
W0208 08:30:57.503935 1274445 log_rpc_server.go:424] Canceling the context after the transaction has been started. See issue #2341
W0208 08:30:57.504281 1274445 tree_storage.go:408] TX commit error: context canceled, stack:
goroutine 90 [running]:
runtime/debug.Stack(0xc0000d5d00, 0xcf6860, 0xc00006a290)
        golang/src/runtime/debug/stack.go:24 +0x9f
github.com/google/trillian/storage/mysql.(*treeTX).Commit(0xc0005ba0c0, 0xd03dd8, 0xc000389780, 0x0, 0x0)
        home/go/src/github.com/google/trillian/storage/mysql/tree_storage.go:408 +0xda
github.com/google/trillian/server.(*TrillianLogRPCServer).commitAndLog(0xc0003d0000, 0xd03dd8, 0xc000389780, 0x1bd36af90d2a12dd, 0xd0a168, 0xc0005ba0c0, 0xc46e12, 0x16, 0xc000256da8, 0x0)
        home/go/src/github.com/google/trillian/server/log_rpc_server.go:723 +0x63
github.com/google/trillian/server.(*TrillianLogRPCServer).GetLatestSignedLogRoot(0xc0003d0000, 0xd03dd8, 0xc000389780, 0xc0002f8b80, 0x0, 0x0, 0x0)
        home/go/src/github.com/google/trillian/server/log_rpc_server.go:442 +0x517
github.com/google/trillian._TrillianLog_GetLatestSignedLogRoot_Handler.func1(0xd03e80, 0xc0005da210, 0xbe4d40, 0xc0002f8b80, 0xd03e80, 0xc0005da210, 0xc6c160, 0x581418)
        home/go/src/github.com/google/trillian/trillian_log_api.pb.go:3377 +0x89
github.com/google/trillian/server/interceptor.ErrorWrapper(0xd03e80, 0xc0005da210, 0xbe4d40, 0xc0002f8b80, 0xc000074740, 0xc0002ce690, 0x0, 0x0, 0x0, 0x0)
        home/go/src/github.com/google/trillian/server/interceptor/interceptor.go:538 +0xbe
github.com/google/trillian._TrillianLog_GetLatestSignedLogRoot_Handler(0xc1b720, 0xc0003d0000, 0xd03e80, 0xc0005da210, 0xc00032a5a0, 0xc6c1b0, 0xd03e80, 0xc0005da210, 0xc0002573a0, 0xa)
        home/go/src/github.com/google/trillian/trillian_log_api.pb.go:3379 +0x150
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0003ce000, 0xd095b8, 0xc000102300, 0xc0005c8100, 0xc00039a870, 0x10f2f38, 0x0, 0x0, 0x0)
        home/go/pkg/mod/google.golang.org/[email protected]/server.go:1082 +0x52b
google.golang.org/grpc.(*Server).handleStream(0xc0003ce000, 0xd095b8, 0xc000102300, 0xc0005c8100, 0x0)
        home/go/pkg/mod/google.golang.org/[email protected]/server.go:1405 +0xccf
google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc000394350, 0xc0003ce000, 0xd095b8, 0xc000102300, 0xc0005c8100)
        home/go/pkg/mod/google.golang.org/[email protected]/server.go:746 +0xab
created by google.golang.org/grpc.(*Server).serveStreams.func1
        home/go/pkg/mod/google.golang.org/[email protected]/server.go:744 +0xa5
W0208 08:30:57.504404 1274445 log_rpc_server.go:725] 2005063877010264797: Commit failed for GetLatestSignedLogRoot: context canceled
...

pav-kv avatar Feb 08 '21 13:02 pav-kv