cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

kvserver: remove ad-hoc queue stats from RaftTransport

Open pav-kv opened this issue 3 years ago • 1 comments
trafficstars

These stats are only printed in text to the logs. There is a queue size metric introduced in 5d51ab34 which properly exports these stats to monitoring. The exported graphs allow observing both the current, and historical queue sizes (including the max size).

This commit removes the queue and queueMax stats as obsolete.

Part of #83917

Release note: None

pav-kv avatar Aug 11 '22 10:08 pav-kv

This change is Reviewable

cockroach-teamcity avatar Aug 11 '22 10:08 cockroach-teamcity

@ajwerner This removes your TODO because it's no longer relevant after this PR: we reduce the granularity of counters. Is it fine, or you would still leave/reword the TODO?

pav-kv avatar Aug 11 '22 14:08 pav-kv

bors r=tbg

pav-kv avatar Aug 11 '22 17:08 pav-kv

Build failed (retrying...):

craig[bot] avatar Aug 11 '22 17:08 craig[bot]

Build succeeded:

craig[bot] avatar Aug 11 '22 19:08 craig[bot]