Patrick Hulce

Results 308 comments of Patrick Hulce

Thanks so much @mathiasbynens for the insights here! > only count main thread time spent parsing + compiling, since that's what matters First, to hopefully calm the immediate alarm bells...

From [the docs](https://chromium.googlesource.com/chromium/src/third_party/+/master/blink/renderer/platform/bindings/RuntimeCallStats.md), it looks like you have to use a feature flag when Chrome is launched in order to get the stats in the trace event, is that accurate?...

Thanks for the note @swissspidy! We'll fix it 👍

fix is up at https://github.com/testing-library/pptr-testing-library/pull/78 but getting this to work in a non-breaking way with typescript is...tricky :) help with tests is welcome

Thanks Barry for filing! This is WAI-ish as the entire project was focused on JS execution time when the site was built. Definitely agree the shift since then hasn't been...

Thanks for the contribution! > I didn't write any test for this because it doesn't change anything on lib behavior, it just adds more room for fine-tuning. Test can be...

Ah shoot, thanks for the ping @Moustachos. Yeah we'd have to adjust our glyph set to handle this multi-glyph case. I don't really have the bandwidth to investigate a fix...

The fix would probably look similar to the multi-byte unicode fix PR (https://github.com/patrickhulce/fontmin-webpack/commit/e0743ba8fe8af549d684122afdcd3b01f206ac55)

Thanks for filing @Abdull! Would you mind sharing what's in your `// ...` and entry file? Our test cases look exactly like our readme and are passing on webpack 5,...

Thanks for filing @technic! The success of this depends a lot on *how* the CSS removal plugin works and at what stages specifically it replaces the webpack asset so that...