Patrick Hulce

Results 308 comments of Patrick Hulce

Mainly just ensuring all the existing tests continue to work as expected and add one for purgecss plugin with a parallel config.

Thanks for the report @scriby could you provide a bit more detail? By hash are you referring to the hash present in the font filename (and the request is for...

> consider providing a new config param that allows us to specify which webpack substitution macro (https://webpack.js.org/configuration/output/#template-strings) like [contenthash], for example, we can use as an alternate way to compute...

Honestly @onpubcom I've been out of webpack for a bit while using other bundlers, so I'm a tad rusty, but is mini-css-extract-plugin not the path you're supposed to use along...

Thanks for filing @KristijanKanalas! I don't really have the bandwidth to dig deeper into this at the moment, but happy to land a PR that fixes it :) A good...

I definitely agree that I'd be nice if labels for uncomputed metrics were gray. In all situations we know that the metrics can't get *better* with time so once it...

I am also +1 to just removing. The last several times that we've hit it or saw large increases the result has always been "we don't really care", so why...

Sparked again by https://github.com/GoogleChrome/lighthouse/pull/10544 > spot the "whoa, what's accidentally getting added here" situations Agreed having *something* that does this is useful but having an arbitrary threshold that fails doesn't...

> about team members having to bump a single number That's not my largest concern, my largest concern is pointing the finger at the correct contributions and not whatever happens...

Thanks for filing @sunithakarthikeyan! I'm not able to reproduce this issue though. Could you provide the rest of the information from the bug template? The only resources I see it...