Patrick Hulce
Patrick Hulce
Currently we require that you supply both the `theme_color` property in the manifest (the one you've linked) *and* the `theme-color` meta-tag. The error is telling you that you have one...
@laukstein meta tag should enable the coloring of the address bar on first load before the manifest has been loaded, so it seems reasonable to include it on PWA entry...
I'm not sure I understand your current proposal @laukstein. > Maybe when Webapp is on homescreen/desktop, Lighthouse mustn't require theme-color if having theme_color in manifest? Lighthouse and users visit the...
I see, so you do not have an issue with requiring both theme-color in meta and manifest anymore then? Is it just that you would like the behavior for when...
@clshortfuse which requirement are you referring to? I'm not sure how either are failing to wait for the load event. In fact, the discussion above is based around frustration that...
Oh, it is a requirement to set `theme_color` in the manifest as well please do not file a separate issue for that. I thought based on your comments about waiting...
> But I am setting it on DOMContentLoad via setting the head attribute. I have a reproducible link at https://family.taximachine.com/app That page is setting a `meta[name=theme-color]` on DOMContentLoad, not the...
These are all good points. I'm inclined to reduce the requirement to `specifies theme-color, warn if theme_color is not set` and just documenting why we suggest setting both. Does anyone...
Thanks for filing @koraa! I agree now that we have the log normal functions defined in terms of the good/average and average/poor points, it makes much more sense to ditch...
> so we'll have to look elsewhere for the signal IMO, we should just use `evaluateAsync('window.location.href')` like we do in DevTools to get the URL to audit. It will likely...