Anthonios Partheniou
Anthonios Partheniou
I had to manually fix the docs build to unblock a [release PR](https://github.com/googleapis/google-cloud-python/pull/11913) that had a comment looking like this: ``` Currently support query strings are: ------------------------------------ ``SplitType=DATASET_SPLIT_TEST|DATASET_SPLIT_TRAIN|DATASET_SPLIT_UNASSIGNED`` ``` The...
See https://github.com/googleapis/googleapis/blob/492e772e24f4122600c0e106945075a8ff3f6255/google/cloud/edgenetwork/v1/resources.proto#L553-L555 where there a list without a list item separator. The proto has ``` // Time this session has been up. // Format: // 14 years, 51 weeks, 6...
Python [3.13.0-alpha.1](https://github.com/actions/python-versions/releases/tag/3.13.0-alpha.1-6531259803) is available. We can use the [allow-prereleases](https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#allow-pre-releases) option of `actions/setup-python` to add a presubmit check against a pre-release version of the runtime. https://github.com/googleapis/gapic-generator-python/blob/746466b49d46059375e66f713befb39d718d5c4f/.github/workflows/tests.yaml#L140
There are warnings in the [build logs](https://github.com/googleapis/gapic-generator-python/actions/runs/6984468065/job/19007340405?pr=1873). We should treat warnings as errors so we know when new warnings appear and create tracking bugs to resolve the existing warnings. ```...
The following SphinxWarnings appears in the docs build for `google-cloud-kms` ``` Traceback (most recent call last): File "/usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-kms/.nox/docs/lib/python3.9/site-packages/sphinx/cmd/build.py", line 280, in build_main app.build(args.force_all, filenames) File "/usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-kms/.nox/docs/lib/python3.9/site-packages/sphinx/application.py", line 350, in build...
See https://github.com/googleapis/googleapis/blob/42231337d84e862d417b6d3fd6af50ba0fcf932c/google/cloud/networkmanagement/v1/connectivity_test.proto#L204-L206 where there is a list which is not formatted correctly. This caused the docs build to fail with ``` sphinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-network-management/google/cloud/network_management_v1/types/connectivity_test.py:docstring of google.cloud.network_management_v1.types.connectivity_test.Endpoint:38:Block quote ends without a blank...
See https://github.com/googleapis/googleapis/blob/42231337d84e862d417b6d3fd6af50ba0fcf932c/google/cloud/clouddms/v1/conversionworkspace_resources.proto#L473-L475 where there is a list which is not formatted correctly. This caused the docs build to fail with ``` sphinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-dms/google/cloud/clouddms_v1/types/conversionworkspace_resources.py:docstring of google.cloud.clouddms_v1.types.conversionworkspace_resources.MultiColumnDatatypeChange:82:Unexpected indentation. Warning, treated as error:...
See https://github.com/googleapis/googleapis/blob/a549ce6e7b62f6fcb808dfec151bef631c986cd5/google/cloud/securitycentermanagement/v1/security_center_management.proto#L784-L786 where there is a list which is not properly formatted This caused the docs build to fail with ``` Shinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-securitycentermanagement/google/cloud/securitycentermanagement_v1/types/security_center_management.py:docstring of google.cloud.securitycentermanagement_v1.types.security_center_management.UpdateSecurityHealthAnalyticsCustomModuleRequest:32:Unexpected indentation. ``` Instead of ```...
See https://github.com/googleapis/googleapis/blob/492e772e24f4122600c0e106945075a8ff3f6255/google/shopping/merchant/reports/v1beta/reports.proto#L355-L361 where there is a table defined in proto comments. ``` // Free listings | Shopping Ads | Status // --------------|--------------|------------------------------ // Approved | Approved | ELIGIBLE // Approved...
https://github.com/googleapis/gapic-generator-python/blob/043ce05a7493ab2892b3e2c72c2b715e81e5b0d9/gapic/templates/setup.py.j2#L22-L25 `version_candidates` is 0 when the release version is a release candidate. For example, `0.35.0rc1` instead of `0.35.0` will fail at installation time