Anthonios Partheniou
Anthonios Partheniou
See https://github.com/googleapis/googleapis/blob/5ce591f2593cf3a2c5c370c0a0d761c2d889c6b1/google/cloud/edgecontainer/v1/resources.proto#L219-L223 where there is an asterisk character which is not surrounded by backticks or escaped. This caused the docs build to fail with ``` sphinx.errors.SphinxWarning: /home/runner/work/google-cloud-python/google-cloud-python/packages/google-cloud-edgecontainer/google/cloud/edgecontainer_v1/types/resources.py:docstring of google.cloud.edgecontainer_v1.types.resources.Cluster.MaintenanceEvent:22:Inline emphasis...
Related to https://github.com/googleapis/gapic-generator-python/issues/1592, code is duplicated in 2 separate directories for templates ([default](https://github.com/googleapis/gapic-generator-python/tree/main/gapic/templates) and [Ads](https://github.com/googleapis/gapic-generator-python/tree/main/gapic/ads-templates)). We should either remove the ads templates, or create shared templates that can be used...
[compliance.proto](https://github.com/googleapis/gapic-showcase/blob/main/schema/google/showcase/v1beta1/compliance.proto) is not used in showcase testing. https://github.com/googleapis/gapic-generator-python/blob/24a23a1ab885246e447c0010b2e5602209dfbb8d/noxfile.py#L242-L253 If `compliance.proto` is added, 2 generated tests fail. See the stack trace below and PR https://github.com/googleapis/gapic-generator-python/pull/1992 https://github.com/googleapis/gapic-generator-python/actions/runs/8381341747/job/22952651655?pr=1992 ``` [__________________ test_repeat_data_simple_path_field_headers __________________ [gw0]...
This PR - Adds [google/showcase/v1beta1](https://github.com/googleapis/gapic-showcase/tree/main/schema/google/showcase/v1beta1) to the goldens directory. - Updates the version of googleapis to the latest SHA Wait for https://github.com/googleapis/gapic-showcase/pull/1477
I successfully generated a GAPIC client for [google/showcase/v1beta1](https://github.com/googleapis/gapic-showcase/blob/main/schema/google/showcase/v1beta1/BUILD.bazel) with `autogen-snippets=False`. When `autogen-snippets=True`, the generation fails with the following error ``` (py39) partheniou@partheniou-vm-3:~/git/gapic-generator-python$ gbazelisk run //tests/integration:showcase_update ERROR: /usr/local/google/home/partheniou/git/gapic-generator-python/tests/integration/goldens/showcase/BUILD.bazel:3:10: //tests/integration/goldens/showcase:goldens_files: invalid label...
In PR https://github.com/googleapis/gapic-generator-python/pull/1985, support was added to automatically populate fields UUID4 fields according to https://google.aip.dev/client-libraries/4235. This issue tracks adding additional showcase tests once the following feature has been added to...
[interceptors](https://github.com/search?q=repo%3Agoogleapis%2Fgapic-generator-python%20interceptors&type=code) are currently supported for REST transport. We should also add support for interceptors in gRPC to have feature parity between both transports. https://github.com/googleapis/gapic-generator-python/blob/24a23a1ab885246e447c0010b2e5602209dfbb8d/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/transports/rest.py.j2#L74-L77 Also see https://github.com/googleapis/python-spanner/blob/4da06a6a883c0513d7c80f9462c871b0a00a8f2b/google/cloud/spanner_v1/testing/database_test.py#L31-L35
From https://github.com/googleapis/gapic-generator-python/pull/1975#discussion_r1529207661 in PR https://github.com/googleapis/gapic-generator-python/pull/1975, See suggestion below to improve readability of tests that require building descriptors from protos. > If it's trivial to read from a proto "file" (string)...
See https://github.com/googleapis/googleapis/blob/2a40f63ea714c7f4c6856a5db4d1f3cc7d4c4b18/google/chat/v1/space.proto#L265 where there is an asterisk character which is not surrounded by backticks or escaped. This caused the docs build to fail with ``` sphinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/google-cloud-python/packages/google-apps-chat/google/apps/chat_v1/services/chat_service/async_client.py:docstring of google.apps.chat_v1.services.chat_service.async_client.ChatServiceAsyncClient.get_space:39:Inline emphasis...