Anthonios Partheniou
Anthonios Partheniou
This PR updates the presubmit checks to also verify the unit tests and coverage for the generated golden files.
This issue was originally reported in python-compute [here](https://github.com/googleapis/python-compute/issues/245). The generated client for python-compute has a [types.py](https://github.com/googleapis/googleapis-gen/blob/master/google/cloud/compute/v1/compute-v1-py/google/cloud/compute_v1/types/compute.py) file which has ~60,000 lines of code and is greater than 2.5 MB. This...
[This getting started doc](https://github.com/googleapis/gapic-generator-python/blob/main/docs/getting-started/local.rst) references [api-common-protos](https://github.com/googleapis/api-common-protos) which contains outdated proto files. The docs should be updated to use [googleapis](https://github.com/googleapis/googleapis) instead of [api-common-protos](https://github.com/googleapis/api-common-protos). The command should be ``` protoc google/cloud/vision/v1/*.proto \...
The generated code includes a dependency on `setuptools`. It appears that `setuptools` is only needed to get the version of the gapic client via `pkg_resources`. See import statement here https://github.com/googleapis/gapic-generator-python/blob/48c46e3a802ec8d2a69c825b874e73d154a512bf/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py#L20...
For python-gke-hub, I added a workaround in owlbot.py [here](https://github.com/googleapis/python-gke-hub/blob/main/owlbot.py#L114) to solve the issue temporarily. See the build log [here](https://source.cloud.google.com/results/invocations/e0239f67-4b37-4af1-b9c8-782f69f07b3d/log) from python-gke-hub . Also see related discussion [here](https://github.com/googleapis/python-gke-hub/pull/94#discussion_r740914920). ``` sphinx.errors.SphinxWarning: /tmpfs/src/github/python-gke-hub/google/cloud/gkehub_v1/configmanagement_v1/types/configmanagement.py:docstring...
The `appengine_admin` client has a service called `services` . Unfortunately, `services` is already an implicitly reserved keyword in `gapic-generator-python` templates here: https://github.com/googleapis/gapic-generator-python/blob/master/gapic/templates/docs/%25name_%25version/services.rst.j2 As a result of having `service.rst` referencing another...
After generating the python client for [Service Control API](https://github.com/googleapis/python-service-control), I received the following Sphinx warning ``` "sphinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/python-service-control/google/cloud/servicecontrol_v1/types/distribution.py:docstring of google.cloud.servicecontrol_v1.types.distribution.Distribution:8:Block quote ends without a blank line; unexpected unindent. Warning, treated...
https://github.com/googleworkspace/python-samples/blob/44f307f5548d1c4d225746264a7bc4568e9c735e/drive/snippets/drive-v3/file_snippet/upload_basic.py#L44-L45 [This sample](https://github.com/googleworkspace/python-samples/blob/main/drive/snippets/drive-v3/file_snippet/upload_basic.py) uses the `fields` argument but I don't see this in the [API documentation](https://developers.google.com/drive/api/v3/reference/files/create). It seems to be a bug in the sample code.