Anthonios Partheniou
Anthonios Partheniou
Fixes https://github.com/googleapis/gapic-generator-python/issues/1874 🦕
Python 3.12 support was added in google-api-core [v2.15.0](https://github.com/googleapis/python-api-core/releases/tag/v2.15.0). We should update the template for `setup.py` to require `google-api-core` 2.15.0 for python 3.12 https://github.com/googleapis/gapic-generator-python/blob/44ca686eed9f2272d483fff362c9e637393d0613/gapic/templates/setup.py.j2#L33
See https://github.com/googleapis/googleapis/blob/42231337d84e862d417b6d3fd6af50ba0fcf932c/google/cloud/deploy/v1/cloud_deploy.proto#L1607-L1609 where there is an asterisk character which is not surrounded by backticks or escaped. This caused the docs build to fail with ``` sphinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-deploy/google/cloud/deploy_v1/types/cloud_deploy.py:docstring of google.cloud.deploy_v1.types.cloud_deploy.SkaffoldModules.SkaffoldGCSSource:5:Inline emphasis...
I had to [manually fix](https://github.com/googleapis/google-cloud-python/pull/11670/commits/4ac03586b552448eda5d62e2109fd9dd18ef83d9) a `google-cloud-python` PR that had a comment looking like this: ``` Returns: google.ai.generativelanguage_v1beta3.types.Permission: Permission resource grants user, group or the rest of the world access...
Dependency `google-cloud-common` is needed in the generated client for `google-cloud-filestore`. See the dependency in `setup.py` which was added manually. https://github.com/googleapis/python-filestore/blob/bf24f012b9296d2e744887d5bcf67185aa0ccbac/setup.py#L43 The dependency should be added to the templates [here](https://github.com/googleapis/gapic-generator-python/blob/ecf4bb0bae89c87afa5bb3c6dd307793a4e7e80b/gapic/templates/_pypi_packages.j2#L12C1-L12C1) so...
Unused imports should be removed from generated test code. This may be fixed automatically if we add static analysis (`mypy`) checks on the `tests` directory. Currently we're only running `mypy`...
There are a lot of customizations made to the generated for `gkehub`. See the customizations here https://github.com/googleapis/python-gke-hub/blob/6e9144cb5a9badd2f8a95cfaf2577f86b197ccf6/owlbot.py#L44 One issue is that there are sub-APIs `configmanagement` and `multiclusteringress` which are included...
See the issue mentioned in https://github.com/googleapis/google-cloud-python/issues/10998#issuecomment-1509873131 where change is needed to the generator to specify additional dependencies that are required when multiple APIs are shipped together. In this case, `grpc-google-iam-v1`...
There are currently a lot of customizations for the `grafeas` client which were introduced in https://github.com/googleapis/google-cloud-python/pull/8186/ via the `synth.py` file. This issue tracks adding support for the customizations in `gapic-generator-python`...
In PR https://github.com/googleapis/google-cloud-python/pull/11808, the `api_id` field in `packages/google-shopping-merchant-inventories/.repo-metadata.json` is set to `inventories.googleapis.com`. This is incorrect. The correct `api_id` should be `merchantapi.googleapis.com`. See https://github.com/googleapis/googleapis/blob/2c12a275b10a2f04926a1505a5fd1b8acf4a6833/google/shopping/merchant/inventories/v1beta/merchantapi_v1beta.yaml#L3C7-L3C33