Anthonios Partheniou
Anthonios Partheniou
Similar to https://github.com/googleapis/proto-plus-python/issues/426, we should add a presubmit to test protobuf at HEAD (from source) to get early feedback
`ValueError: metadata was invalid` occurs when key in request metadata contains uppercase charactors
See the following test which fails when an uppercase is used in the metadata key https://github.com/googleapis/gapic-generator-python/blob/c72411d4507a4bea08233a527120fe66fec9ae80/tests/system/test_request_metadata.py#L20-L28 ``` def test_metadata_string(echo): echo.echo( showcase.EchoRequest( content="The hail in Wales falls mainly on the snails.",...
See the diff in PR https://github.com/googleapis/gapic-generator-python/pull/2253/files which shows changes to the following code which appears throughout the code base ``` retry: OptionalRetry = gapic_v1.method.DEFAULT, timeout: Union[float, object] = gapic_v1.method.DEFAULT, metadata:...
The `add-iam-methods` option and corresponding nox session `showcase_unit_add_iam_methods` should be removed from the codebase as it is redundant code. https://github.com/googleapis/gapic-generator-python/blob/515dc8ac17b9a8177feaa84416ab88e671c5359c/gapic/utils/options.py#L57 https://github.com/googleapis/gapic-generator-python/blob/515dc8ac17b9a8177feaa84416ab88e671c5359c/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/client.py.j2#L627 https://github.com/googleapis/gapic-generator-python/blob/515dc8ac17b9a8177feaa84416ab88e671c5359c/noxfile.py#L513 Before it can be removed, we need to...
We should be able to add a Github action to flag when there are spelling mistakes in pull requests. It's not clear which tool we should use for spell checking...
Python 3.7/3.8 tests have been disabled in #2623 . We should either remove Python 3.7/3.8 support in the main branch, or restore the tests if/when there is a fix for...
Similar to https://github.com/googleapis/python-api-core/pull/870