Eugene Pakhomov

Consider using `goog.url` instead of `goog.Uri`

2

`goog.Uri` does not decode values correctly and here https://github.com/google/closure-library/issues/1083#issuecomment-700305976 it was suggested that it's almost certainly better to just use `goog.url`.

"Uncaught URIError: URI malformed" when using data URIs

1

Accountant uses `goog.Uri.parse` that in turn uses `decodeURI`, but it cannot parse data URIs that contain binary data that has not been encoded with `base64`. An example of such URI:...

Emit a warning when some parameters are ignored

2

On Clojurians Slack, people ask things like "why my `"Content-Type"` is ignored" once every month or two, or at least it feels that way. I myself have had some issues...

To reproduce: 1. Go to https://naomiaro.github.io/waveform-playlist/annotations.html 2. Enable Automatic Scroll at the bottom 3. Scroll the waveform so it's not at the starting position 4. Try dragging any annotation Observed...

TypeError: Cannot read properties of undefined (reading 'disconnect')

2

Once every few weeks I can see this error in the logs: ``` TypeError: Cannot read properties of undefined (reading 'disconnect') File "node_modules/waveform-playlist/lib/Playout.js" line 73 col 21 in AudioBufferSourceNode.source.onended this.source.disconnect();...

Issues with audio and animation at the Configurator page

1

To reproduce, go to https://configurator.abcjs.net/audio and make sure `Animage?` is checked. Now, press play, pause, rewind a few times. And then press play and pause immediately. You should see something...

Crash when trying to render a note whose symbol is unknown

1

Example ABC: ``` X:1 T: L:1/8 M:4/4 Q:1/4=120 V:1 K:C C/23 ``` JS console shows this: ``` noteSymbol: note -8 false abc_abstract_engraver.js:720 Uncaught TypeError: Cannot read property 'c' of undefined...

Seeking with the progress indicator can be erratic

1

There are two issues with it: - There's no dragging which is usually expected by end users, and seems like it used to be there in v5 as implemented by...

Using octave clefs is not rendered correctly

2

E.g. add `K: treble+8` at https://www.abcjs.net/abcjs-editor.html Notice how the rendered notes aren't changed at all, although the clef itself is changed correctly. Same with `-8`. And `+15` and `-15` are...

The docstring says: ``` An interceptor which logs/instruments an event handler's actions to `js/console.debug` ``` The actual implementation in `re-frame.std-interceptors` uses: ``` (console :log "Handling re-frame event:" (get-coeffect context :event))...