re-frame icon indicating copy to clipboard operation
re-frame copied to clipboard

Incorrect docstring for `re-frame.core/debug`

Open p-himik opened this issue 4 years ago • 0 comments

The docstring says:

An interceptor which logs/instruments an event handler's actions to
  `js/console.debug`

The actual implementation in re-frame.std-interceptors uses:

(console :log "Handling re-frame event:" (get-coeffect context :event))
[...]
(console :log "only before:" only-before)
(console :log "only after :" only-after)

Apart from using an incorrect level, the docstring also mentions js/console, which is incorrect.

I'd argue that both places should use/mention re-frame.core/console. And definitely use/mention the same logging level, but whether :log or :debug I'm not sure.

p-himik avatar Feb 08 '21 19:02 p-himik