abcjs icon indicating copy to clipboard operation
abcjs copied to clipboard

Using octave clefs is not rendered correctly

Open p-himik opened this issue 4 years ago • 2 comments

E.g. add K: treble+8 at https://www.abcjs.net/abcjs-editor.html Notice how the rendered notes aren't changed at all, although the clef itself is changed correctly. Same with -8. And +15 and -15 are not supported at all, although it's another common octave clef.

I understand that those are documented in a draft at http://abcnotation.com/wiki/abc:standard:v2.2#octave_clefs. But -8 and +8 aren't documented in the v2.1 either, just mentioned, so seems like it would make sense to support both 8 and 15.

p-himik avatar Jul 13 '21 13:07 p-himik

I interpreted the "+8" as not changing the written music, just the synth. At this point it would probably break a lot of tunes to change it. I wasn't aware of the "+15". I'd be open to adding that, but I think it should work the same way: not change the written music, just the synth.

paulrosen avatar Jul 17 '21 14:07 paulrosen

At this point it would probably break a lot of tunes to change it

Not if there's an extra feature flag for it, one that affects the written music and maybe the synth as well.

p-himik avatar Jul 17 '21 15:07 p-himik