cljs-ajax icon indicating copy to clipboard operation
cljs-ajax copied to clipboard

Emit a warning when some parameters are ignored

Open p-himik opened this issue 2 years ago • 2 comments

On Clojurians Slack, people ask things like "why my "Content-Type" is ignored" once every month or two, or at least it feels that way. I myself have had some issues after forgetting what I should provide with what.

Perhaps, cljs-ajax could warn its users that e.g. a user has provided some :format that will be ignored because :body was also set.

p-himik avatar May 02 '22 17:05 p-himik

Not a bad idea. Want to try creating a PR for it?

On Mon, 2 May 2022 at 18:27, Eugene Pakhomov @.***> wrote:

On Clojurians Slack, people ask things like "why my "Content-Type" is ignored" once every month or two, or at least it feels that way. I myself have had some issues after forgetting what I should provide with what.

Perhaps, cljs-ajax could warn its users that e.g. a user has provided some :format that will be ignored because :body was also set.

— Reply to this email directly, view it on GitHub https://github.com/JulianBirch/cljs-ajax/issues/275, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAURE2C2RY3RGU34XFXRJTVIAGBNANCNFSM5U4SZVVA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Sent from an iPhone, please excuse brevity and typos.

JulianBirch avatar May 03 '22 22:05 JulianBirch

If only I had more time. :) I'd definitely have to spend much more time reading the code to make sure that I understand what is ignored under which conditions.

p-himik avatar May 04 '22 07:05 p-himik