Claudio Wunder
Claudio Wunder
> the search input appears to have the same contrast issue too. > > > > > > I feel that the search input one was intentional, but indeed it...
@flakey5 @targos I believe we can do it asap, right?
Do we have any update here? @flakey5 apparently these folders mentioned above don't exist on r2? Is something missing here yet? 🤔
I'm not sure I understand what it is complaining about here. @flakey5, is our index template not having a closed tag or something?
> `lint-js-and-md` is failing because of the linting errors since it exits with a non-zero status code if there's anything wrong with the docs. I think we should skip the...
@flakey5: ``` 3:1-3:9 warning Use "the Node.js" instead of "Node.js'" prohibited-strings remark-lint 4:46-4:50 warning Use "Node.js" instead of "Node" prohibited-strings remark-lint ``` On the README.md file you updated (`tools/doc/README.md`) after...
cc @nodejs/collaborators can we have another approval here? 🙏
cc @jasnell would you like to review?
I wonder if the failures are even related?
> > I think they are related, it can't find a node binary when running `npm install` in `tools/doc`. Will take a look in a bit > > > >...