nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Improve inactive codebox tab text on light mode

Open bmuenzenmeyer opened this issue 1 year ago • 5 comments

Lighthouse is dinging us for poor contrast here

This is only in light mode

image

bmuenzenmeyer avatar Mar 24 '24 14:03 bmuenzenmeyer

in our system design the codebox has a light style, why we don't apply it? I think the discussion has already taken place but I can't find it.

AugustinMauroy avatar Mar 24 '24 17:03 AugustinMauroy

the search input appears to have the same contrast issue too.

image

surengalstyan avatar Mar 24 '24 19:03 surengalstyan

the search input appears to have the same contrast issue too.

image

I feel that the search input one was intentional, but indeed it does not pass accessibility tests. We should fix it!

ovflowd avatar Mar 24 '24 22:03 ovflowd

in our system design the codebox has a light style, why we don't apply it?

we decided to only have one. it might have been shikiji-related?

bmuenzenmeyer avatar Mar 24 '24 23:03 bmuenzenmeyer

we decided to only have one. it might have been shikiji-related?

it would be cool to have both but i'm willing to bet it will increase the bundle size

AugustinMauroy avatar Mar 25 '24 08:03 AugustinMauroy