Claudio Wunder

Results 1165 comments of Claudio Wunder

> I tried to run `make docserve -j` on this branch and got the following error: > > ``` > Error: Command failed: git remote get-url origin > error: No...

> > I tried to run `make docserve -j` on this branch and got the following error: > > ``` > > Error: Command failed: git remote get-url origin >...

> > > I tried to run `make docserve -j` on this branch and got the following error: > > > ``` > > > Error: Command failed: git remote...

I've made a PR to fix the current failures: https://github.com/nodejs/api-docs-tooling/pull/231

> > In short: everything was working fine > > How is it working fine if it reports `REPLACEME` as an invalid version? Apparently GitHub shows the file contents from...

The branch got rebased and it seems to be correctly saying which YAML blocks have errors. Although, cc @araujogui it'd be good if it shown the **exact** line within the...

> I mean, not showing the correct line is indeed something we should try to fix (but IMO not blocking). However, I think a more problematic behavior is to report...

> Tests are failing due to [nodejs/api-docs-tooling#228](https://github.com/nodejs/api-docs-tooling/pull/228), however this function _should_ be exported from `node:fs` in the generated node executable. I can revert the PR if needed, but I don't...

But FWIW @avivkeller let’s not use experimental features on the api doc tooling. Add the glob package back and lets just stay on the safe side :)