Oscar Gustafsson

Results 474 comments of Oscar Gustafsson

97 minutes is probably a bit too much. Not sure I fully followed the discussion in #28543 but at least running it in a separate worker would be a good...

I think it is better that someone "more senior" replies to this. The only thing I am pretty sure about is that a 97 minutes CI job will not be...

Sorry, was hoping that someone would pop in. I've added it to the next dev-call (which is tomorrow evening, feel free to join https://hackmd.io/l9vkn_T4RSmk147H_ZPPBA ). Will try to attend, but...

Isn't there a point at keeping the MSRV as low as possible? That is, if needed, from dependencies or language features, bump it, but not just for the sake of...

Quite hard to do any sort of debugging without more context. Are you sure that whatever you are running in the browser is built with egui 0.27.1 or newer? If...

Can you please add a test that generates the image that you show above?

The error comes from here: https://github.com/VUnit/vunit/blob/4e30fa124ea84609af0f957dbc55b82adaed1d76/vunit/project.py#L326 I *think* the parsing of architecture name happens here: https://github.com/VUnit/vunit/blob/4e30fa124ea84609af0f957dbc55b82adaed1d76/vunit/vhdl_parser.py#L1005 Probably, the solution is to add `\s*` between `\((` and between `)\)` towards the...

> maintain the expectations that changing the version of cargo should not change your Cargo.lock Is this really relevant if the new Cargo.lock is improved? Then, naturally, I understand the...

I'd say that this is similar to not pulling in transitive dependencies of disabled features in used dependencies (which I am quite convinced is the case, e.g., based on the...