Oscar Gustafsson

Results 474 comments of Oscar Gustafsson

I cannot really say anything regarding the maths except that it seems to work. What happens if you get the symbolic limit of a `Piecewise`?

OK! I was just curious since this returns a Piecewise, so I wondered if it would be a Piecewise of Piecewises or a folded version. But I realize that there...

It would be nice to get this in. Maybe OK to bump the MSRV? (Is the Debian theory correct? My impression is that many crates set the MSRV for information,...

> Right now, I do not know about any behaviour change due to this and the gethostname crate is so small that it should not matter much to have it...

You are correct. I thought `parse_regex` was part of the public API somehow, but was wrong. Btw, I noted that you have a separate branch for the releases. Is this,...

> I think that, in order to fix that, we should add our own private, internal error type for the `FromStr` impl for MatchPattern`that wraps the`matchers::BuildError`and implements`std::error::Error`. This wrapper type...

@hawkw Would you mind starting the workflow? Interesting to see if this solves the issue and then we/you can discuss if it is an acceptable solution.

Since matchers hasn't accepted to PR, I've updated this to add an explicit dependency on regex_automata. Not sure if this affects MSRV, but let's see... Sorry for letting this slip,...

Comment added. Good idea indeed!

Bumped to 1.65. As I changed the CI to run on 1.65, I also bumped all other subcrates to that. Not sure if that is the way to go or...