egui icon indicating copy to clipboard operation
egui copied to clipboard

POC: Bump rust-version to `1.78`

Open bircni opened this issue 1 year ago • 3 comments

As mentioned in the last update https://github.com/emilk/egui/pull/4411 it's ok to be 2 versions behind and I think this would be useful. To make this work I also updated the wasm version from 0.2.92 to 0.2.93

  • [x] I have followed the instructions in the PR template
  • [x] I ran the script in ./scripts/check.sh

bircni avatar Aug 13 '24 22:08 bircni

To fix #4961 I also bumped web-sys to the newer version

bircni avatar Aug 14 '24 15:08 bircni

Isn't there a point at keeping the MSRV as low as possible? That is, if needed, from dependencies or language features, bump it, but not just for the sake of it?

(In my project, we had some reports after egui required 1.76 as it could not be built on some platforms.)

Then it of course makes sense to test using the minimum version as well as the most recent (and possibly beta and nightly to catch upcoming problems).

oscargus avatar Aug 18 '24 07:08 oscargus

@oscargus yeah you are right first it was just like a poc Maybe i gonna set this as a draft for later and put the web_sys fix into another pr

bircni avatar Aug 18 '24 10:08 bircni