optout
optout
There are 4 `Mutex` fields, used for testing/fuzzing: I placed them under refcounting (`Arc), so they can be cloned. The only non-cloneable field is the signer. The signer could also...
Still up for discussion, different approaches being discussed, to get rid of per-field cloning: - change inside Signer so that it is clonable (it is not due to atomic counters)...
Documentation updated per the suggestions
> LGTM modulo one small change Changed (also rebased)
Note: related: #3281
A current proposal for channel states/phases is described here: https://gist.github.com/optout21/2ead7a0f4e2c3d34aed1c9703c8cfb39
In `rust-bech32`, option with no-trimming 5-bit-to-8-bit conversion is on its way. When it's available (in a new release), the pre-padding in LDK can be removed -- in `Bolt11Features` serialization and...
Relevant comments from #3407: - [X] `value_to_self_msat` doesn't include fees and anchor outputs value, to be considered similar to how it's done in `build_commitment_transaction` https://github.com/lightningdevkit/rust-lightning/pull/3407#discussion_r1970725164 - [ ] https://github.com/lightningdevkit/rust-lightning/pull/3407#discussion_r1970522088 -...
Suggestions implemented; for reserve requirement check, the balance is adjusted with fees and eventual anchor output value (see 6ec1a190bdf3a0dae19964f7b9c9e971434c294c). On hold, waiting for #3407 to land first.