optout
optout
Rebased, post #3407 .
Fixes done: - Fix Pre&Post reserve check - Assert that there are no pending HTLCs - Move splice reserve checks to FundedChannel, because few other fields are needed (is_v2, reserves...
Rebased to refresh
Rebased to recent main (post- #3736 ), more cleanup needed.
Concept ACK 61cd0e53ca45684cd5ef9084829ecc6d59154595 I notice that `CTransaction::ToString()` prints the inputs and the input script witnesses additionally, with that change script witnesses will be included duplicated. The order there is first...
A general observation: keeping a count like the dirty count is very efficient, but prone to going out of sync, e.g with future incorrect code changes. For eg., a missing...
There is no direct C++ unit test for `getCoinbase`/`ExtractCoinbaseTemplate`, would it make sense to add one? Or is the interface test sufficient (`test/functional/interface_ipc.py`)?
Concept ACK (d926d31603316a10e3210f10480dd02bb34f667a) The added new method makes sense. The deprecating methods are only being marked in the header comments, they are kept, there is no formal plan for deprecation....
I suggest splitting into two commits: - Preparatory rename & new parameter(s) but without behavior change, to minimize diff in 2nd commit (rename ALWAYS to FORCE_FLUSH I suppose) - Change...
reACK 14abac10f2ebd93367c91dde7586a35456ef9d45 (prev: re utACK d4425982ca4aff9b856a26f1d83d1419252f10a2 utACK a59aacefd1a0cdb448c8f847665a5809f9897605)