rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

[Splicing] Signer extended with method to sign prev funding transaction input

Open optout21 opened this issue 1 year ago • 1 comments

Fixes #3312 . (#1621 )

New method to sign an input of a transaction with our funding key. Used for splicing, when signing the previous funding transaction. The previous funding transaction becomes an input to the new funding transaction, and it is a multisig, which we also need to sign.

optout21 avatar Sep 16 '24 12:09 optout21

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 89.56%. Comparing base (0db051b) to head (f22b011). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/sign/mod.rs 0.00% 20 Missing :warning:
lightning/src/util/test_channel_signer.rs 0.00% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3316      +/-   ##
==========================================
- Coverage   89.61%   89.56%   -0.05%     
==========================================
  Files         127      127              
  Lines      103534   103560      +26     
  Branches   103534   103560      +26     
==========================================
- Hits        92781    92756      -25     
- Misses       8053     8101      +48     
- Partials     2700     2703       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 16 '24 12:09 codecov[bot]

Documentation updated per the suggestions

optout21 avatar Oct 14 '24 09:10 optout21

LGTM modulo one small change

Changed (also rebased)

optout21 avatar Oct 15 '24 21:10 optout21