optout
optout
Fixed build error in 1st commit (the `extern`, etc, was added to the 2nd commit only, was missing from 1st).
> 2 errors generated. > Fixed in 464ce57745894d4038c970c5baac3c9da5933c19
Applied review comment changes to `chain_tests.cpp`. -> 2f77d8dd91a87071bc01cfb5b68f01ab176f06f7
> I might have gone a bit overboard, but I have tried explaining every change that I suggested in context. Thanks for the details comments; addressed case-by-case.
> So I think it's worth considering one of those two approaches I agree, point taken. I have considered adding the counting to the product code, but it's not a...
Regarding model/approximation (https://github.com/bitcoin/bitcoin/pull/33661#discussion_r2620420093): - If there was only the 1-bit clearing (applied for even numbers), the expected average for the skip is $log(y) - 1$. For the number of iterations,...
Reworked based on the comments (@l0rinc @sipa, thx): - I switched to chain of len 1,000,000, for better fit with actual main chain. - The start I chose to be...
An observation regarding the original code in `CBlockIndex::GetAncestor`: These two lines: ```C++ int heightSkip = GetSkipHeight(heightWalk); int heightSkipPrev = GetSkipHeight(heightWalk - 1); ``` could be changed to ```C++ const int...
reACK d870caca33ac9f0fdd76969a7341535c5722417e ([prev](https://github.com/bitcoin/bitcoin/pull/33192#pullrequestreview-3171424512))
reACK d9319b06cf82664d55f255387a348135fd7f91c7 (was reACK 21cff12b0e6dc58fb8c66543bbd713796d9941ae)