Olivier Goffart

Results 270 comments of Olivier Goffart

But it is still not supported for [OpenFileOptions](https://docs.rs/ashpd/0.3.2/ashpd/desktop/file_chooser/struct.OpenFileOptions.html)

> Calling build on integration test file separately does not work either. Why doesn't that work? I guess then what you need to do is to move such tests to...

What is the real use case you have in mind for this feature? The C++ compilation is done before the rust compilation, and as such the C++ do not have...

I think for the enum use case, the best is to use the `bindgen` tool. But apart from that, this can still be useful. For the implementation, it kind of...

But the extra whitespace is not really a problem, is it?

What's important is that the error message the the compiler still points to the right location. The trailing whitespace at the end of the line don't matter, but if it...

Yeah, `cpp_class` only work with class that are relocatable. This is documented there: https://docs.rs/cpp/0.5.5/cpp/macro.cpp_class.html#relocatable-classes Perhaps the documentation should be more explicit, or extra warning should be in order.

This depends on the implementation of the standard library.

Internally it is returned from the `Test::new()` function so that's one possible relocation (even if it might be optimized) Also internally in the cpp! macro

``` let c_string: *const u8 = CString::new(str)?.as_bytes_with_nul().as_ptr(); ``` This is not related to the assertion, but this does not sounds correct, because CString::new() will allocate a copy of the string,...