Olivier Goffart

Results 270 comments of Olivier Goffart

I can also help with review and maintenance, as I'm relying on corrosion in a project.

Thanks for looking into that. I really didn't want to investigate what needed to be fixed there and this is why i pinned the previous version.

Yes, we can increase the msrv for newer msvc. If someone can increase the msvc version, they certainly can upgrade rustc

Should we really have a different MSRV for the generator and the user code? One without the other doesn't really make sense.

I don't understand what this fixes. Is it possible to make a test?

Ok. I must admit i don't understand this one. But if you do, go ahead!

I guess that depends what's the use case for this feature. In my case, i select specific sub-crates of a workspace. And so cago test would run the test for...

> (it would be possible to permit a sentinel value, like null, to be used, but that would imply that upcasting must have a branch, making it less efficient). I...

> It might be possible to work around this by pre-filling the image on the example side. I don't think we should attempt a work around. We should ideally fix...