Offir Golan

Results 156 comments of Offir Golan

@GCorbel I'm sorry but I'm on vacation and I dont have time to check this logic out for the next 2 weeks. If you are using this via ember-cp-validations, you...

@GCorbel can we put this behind an `allowComas` flag?

@igorT this has been discussed and contemplated a lot about a year ago and we decided that we will not support international phone numbers. There are too many factors to...

@urbany yeah that repo is a bit overkill. I suggest creating your own validator with that API if that is what you need.

@mydea I'm actually not too sure whats going on here. All this addon does is provide a validate function for ember-changeset to test values against. It has nothing to do...

@bgentry you're right. There are definitely some inconsistencies here. What are your thoughts about instead using `allowNone` which will use Ember.isNone and `allowEmpty` which will use Ember.isEmpty? All of which...

I think the only blocking issue that I know of are the transforms lookup (#5). @mpirio might be of more help here.

No it does not since you will be using the ember-changeset API to see the error messages.

@Andarist these all feel like workarounds when 2/3 of the types can already be typed via the generics. Ideally, a 3rd generic parameter can be exposed so we can properly...

Thanks, I appreciate it. > I recommend sticking to inference over explicit type arguments. Looking at the type for `fromCallback`, it wont infer the `sendBack` event type since its not...