Offir Golan

Results 156 comments of Offir Golan

@NouranMahmoud this seems to be a discovery issue on your end. I think think there is much I can do on the library side. If I'm understanding this correctly, you...

@MatthewPringle Im not sure I follow you here. Can you add some more details and maybe some code snippets?

@MatthewPringle I think the issue is because you didnt add the necessary dependent key to your `conditional` validator. See below: ```js const Conditional = BaseValidator.extend({ validate( value , options ,...

Also, why is your `disabled` option `volatile`? I dont think thats necessary.

It seems like the issue here has something to do with the `isDescriptor` utility method. Do you happen to know why that might be?

> For 3.10 I had to update addon/-private/options.js to make the constructor always extend the object. This is very expensive to do and I would prefer to fix the underlying...

@toovy @GCorbel sorry for the delay, Im out of the country so my response times may be a bit slow. I don't really have the time to look too much...

@GCorbel I think the best and fastest solution as of right now would be to create _ember-cp-validations-ds-errors_. I'm gonna be traveling the next few weeks so I wont have too...

Hi @teddyzeenny thank you for compiling this! > This Validations variable survives across app resets/destruction (which means it survives between tests) because it's used by the ValidationsMixin whose lifetime is...

@teddyzeenny if you follow the model trail it leads [here](https://github.com/offirgolan/ember-cp-validations/blob/f0f8a92fdc2d09721b7acc4afd61fdbfae33e030/addon/validations/factory.js#L561). The `validations` class never actually stores the reference to the model instance, only uses it to get access to the...