adopted-ember-addons
Allow to use coma in numbers
In french, and in some other languages, coma are used instead of dos to separate numbers.
Not sure about the implementation but I didn't found an other way.
@GCorbel I agree with you, this is certainly an issue I havent faced yet. Im not really sure if this is the best approach though or if it will break anything upstream.
It works for me. We may have an option like allowComas: true. What you think ?
@offirgolan I need your feedback for one project. Please, let me know if you think my proposition is good or not.
@GCorbel I'm sorry but I'm on vacation and I dont have time to check this logic out for the next 2 weeks. If you are using this via ember-cp-validations, you have multiple ways of doing this with public API.
- You can create your own number validator by extending the existing one.
- You can use the
valueoption to format the number string.
Hopefully that will unblock you until I have more time to verify this PR.
@offirgolan This PR looks relatively straightforward, any chance we can get it merged?
