Offir Golan comments

Results 156 comments of


                                            Offir Golan

Performance problems

@runspired I would love to chat more about this when we both have some free time 😄

error calling model.validate from Unit test (solved by including validator:ds-error in "needs")

@rwjblue should I convert the default unit test blueprint to be an integration test then?

Table Selected Rows Ordering

@mkay581 @buschtoens IMHO A better solution would be to add another action that would trigger on row(s) being selected and pass those row(s) up. This provides a lot more flexibility...

Table Selected Rows Ordering

@buschtoens take a look at #193. It was never finished 😞 Pretty much we can pass these into `onRowClick` ```js onRowClick(row = Row, selected = [], deselected = [], e)...

3D Transforms Break scrollTop and position: fixed

@josiahbryan let me investigate this. I believe I'm running into the same issue on one of my projects as well.

3D Transforms Break scrollTop and position: fixed

@josiahbryan I actually have not been able to reproduce this in my app. I have `postion: fixed` working as intending within a burger menu outlet. Any chance you can reproduce...

3D Transforms Break scrollTop and position: fixed

No worries at all, I totally understand. I'll keep this issue open 😄

Proxyable row options

@billdami thank you for submitting this PR! Although I understand the use-case for this, I dont believe this is the correct solution. In all honesty, with the current implementation, I...

Proxyable row options

@billdami I'm glad you feel the same way! I totally agree with you on the fact that this needs some much needed discussion. As of right now, there are some...

if two models have two attributes with the same name, how can we get from the error validations object the modelName info for each attribute?

@NouranMahmoud any chance you can reproduce this in a twiddle so I can play around with it?