omar

Results 2356 comments of omar

The triangle is used during rendering of thick lines. It doesn’t need to be bigger. If you have a rendering issue please submit the rendering issue with all requested information....

FYI the assert was added by 604f2fa84a following me investigating #3946. I suppose even if the feature was always partially broken (hence #3946) it also had use. Going to investigate...

Functions from imgui_internal.h are not exposed. Same as #485, #250 and #81

You seem to be overlooking that there are vastly too many changes in there. It's impossible to review and merge a PR that modify hundreds of lines of the most...

I'll give you an example of required divide of conquer: - if you are going to move a bunch of code in the `ImGui_ImplVulkanH_CreateRenderPass()` function, make that happen in a...

You can split into separate commits as part of the same part. Use git interactive rebase to split the commits, and force-push into branch PR. This way we have the...

> So one big PR with multiple commits is good for you? (I remember you wanted it all to be squashed last year) It needs to be squashed when the...

Hello, I am right that this draft PR should be closed? in favor of #8061 #8110 #8111 ? It's a bit confusing to deal with PR which all seem to...

You can push or force push to a same PR to update it! But FYI doing multiple unrelated things in a same PR is the best way to get it...