omar

Results 2356 comments of omar

- Why is `emscripten_set_wheel_callback` called in the `ImGui_ImplGlfw_InstallEmscriptenCanvasResizeCallback()` function? - I think the `printf("")` may be replaced by an assert() with comments.

Thanks! I didn't realize this was the fix for #7600. I'll try to test this now.

I wonder if we should: - rename `ImGui_ImplGlfw_InstallEmscriptenCanvasResizeCallback()` to `ImGui_ImplGlfw_InstallEmscriptenCallbacks()` - we can easily add an inline redirect under `#ifndef IMGUI_DISABLE_OBSOLETE_FUNCTIONS` block. - KEEP calling `ImGui_ImplGlfw_InstallEmscriptenCallbacks()` even for your port....

Is this mergeable? Topics/PR going over multiple things tends to be overwhelming/hard to process for me. I'll just need to fix the coding style but I can do that myself....

It also breaks GLFW compilation without Emscripten. I'll finish this and split into two commits.

No worries I'll finish it, but it's always easier when PR are separated in commits. Here I'll want separate the contrib port support from the ImGui_ImplGlfw_InstallEmscriptenCallbacks() rename.

Merged as 6816789 and 2937339 (with various small changes) I got rid of `ImGui_ImplGlfw_InstallEmscriptenCanvasResizeCallback()` redirect because we have too much cruft, Emscripten is sort of a moving target, and the...

GitHub doesn’t seem to run CI without approval unless a commit(?) or pr(?) has previously been merged from the same author. But i am not sure which rule uses precisely:...

Pushed additional fix a8e96ae (caused by my own leftover during a test)

Is that exactly the code you are actually using/testing with ? Popup Identifiers have to be part of the ID stack to clear ambiguity and allows a same popup to...