balancer-v2-monorepo
balancer-v2-monorepo copied to clipboard
Stable Pool: ongoing reentrancy protection
Description
ComposableStablePool (version 3) was patched for reentrancy; this applies the same (generalized) protections so that any future deployments are safe.
Type of change
- [X] Bug fix
- [ ] New feature
- [ ] Breaking change
- [ ] Dependency changes
- [ ] Code refactor / cleanup
- [ ] Documentation or wording changes
- [ ] Other
Checklist:
- [X] The diff is legible and has no extraneous changes
- [N/A] Complex code has been commented, including external interfaces
- [N/A] Tests are included for all code paths (would be fork tests in the deployment)
- [X] The base branch is either
master
, or there's a description of how to merge
Issue Resolution
This was the patch change: https://github.com/balancer/balancer-v2-monorepo/pull/2206
- what about
disableRecoveryMode
? It already has access to the vault, but I don't see the protection applied in this branch either. EDIT: it's added in #2330
Yes; didn't want to potentially conflict.