Kris Nuttycombe
Kris Nuttycombe
The only rationale for the current implementation is that the insight explorer flags were already depended upon to perform the lookup if you wanted to get the prevout amounts. But...
In discussion with @str4d we agreed that this API should for the immediate time being be moved behind the `unstable` feature flag, but we can defer the full removal until...
@josef-v Does this answer your question? If you need to have the ability to get the balance for a single transparent address, can you answer @str4d's question here: > So...
Now that I've fully read through what's happening here, I think I understand better the difference between this and #6176 - the difference is that this is collecting a set...
This change should also be made for `getunconfirmedbalance`.
The only component of this that needs to block 4.7.0-rc1 is to verify that the current defaulting behavior is *not* used by any current call site invoking the `TransactionBuilder`.
`z_mergetoaddress` uses the transaction builder and does not explicitly set a change address. This is fine, because `z_mergetoaddress` fully consumes its inputs. It will be safer once the assertion is...
`asyncrpcoperation_saplingmigration.cpp` relies upon the default behavior of the transaction builder. Fixed in #5680
`asyncrpcoperation_shieldcoinbase.cpp` correctly sets the change address.
Moving this to block 5.0.0 now that the one concerning place is addressed in #5680