Kris Nuttycombe comments

Results 229 comments of


                                            Kris Nuttycombe

ZIP-222 TZE host logic implementation

@LarryRuane Both of those issues appear to now be resolved with the last two commits. I realized that I can track the version of the previously serialized undo data, and...

ZIP-222 TZE host logic implementation

@zkbot try

`qa/zcash/updatecheck.py` recommends to run `cargo outdated` which is... outdated

Fixed in 1365734

Restore documentation that had been moved to zcash.readthedocs.io

> I'm not quite sure I understand this PR. Are we now going to support 2 sets of user style guides in read the docs and in this repo again?...

Add feePaid to the output of getrawtransaction and getblock at verbosity=2

Moving this back to draft to make it use only `-txindex` instead of requiring the full insight explorer.

Add a `finalState` integer parameter to `z_gettreestate`

Is there a good reason for this to block v5.0.0? It seems like it's not strictly necessary after #5848; I think it should block 5.1.0 instead, if that.

Add an abstraction for fee calculation.

@daira the remaining uses of `DEFAULT_FEE` will be addressed in https://github.com/zcash/librustzcash/pull/689, which builds atop this PR.

Add an abstraction for fee calculation.

[force-pushed](https://github.com/zcash/librustzcash/compare/6280dde..9496fc6118812fc8cc89d8b155d8b5b501348e43) to address review comments.

Add an abstraction for fee calculation.

[updated](https://github.com/zcash/librustzcash/compare/9496fc6..c92d81b15d7adab6a460aa99eee4591e91c0aad1) to address requested changes.

Include the fee amount when returning transaction detail from RPC.

The existing PR that I added for this to serve @sellout's analysis depends upon the insight explorer indices being present; is this okay? Alternately, we could require `-txindex`, or even...