Kris Nuttycombe
Kris Nuttycombe
@AloeareV just to give you a heads-up, we likely won't get to a full review of this for a few days because the team is trying to get zcashd 5.5.0...
Closing in favor of #863
Closing as fixed by #596 - if there is additional work to batch blocks on disk differently, a separate issue should be opened for it.
@pacu after #807, what should the status of this issue be? Does it make sense to close this now (perhaps in favor of more specific actionable items?)
So, I think that we have this: pending funds that are change are explicitly represented in the `sent_notes` table and thereby in `v_tx_outputs` as are explicitly sent notes (outbound value)....
This is being addressed via #900. Closing as subsumed by #900
> if z_getaddressforaccount is called twice on an account which address does the recipient see when funds are sent using z_sendfromaccount? @gesker The recipient never sees the sender's address under...
Related to #5032, #5030
Related to https://github.com/zcash/zcash/pull/2861
We would use a `std::optional` instead of a nullable pointer if we wanted to do this, but really we want to do #6497 instead and delete `GetFilteredNotes` entirely.