librustzcash icon indicating copy to clipboard operation
librustzcash copied to clipboard

Derive Serialize/Deserialize for certain simple structs

Open ec2 opened this issue 1 year ago • 2 comments
trafficstars

This PR introduces "non-controversial" derives of Serialize and Deserialize for some structs that we persist to storage in our memory wallet implementation. This is by no means all the structs that we want to be able to serialize, but they are the ones that should be stable or are simple internal representations.

ec2 avatar Oct 10 '24 19:10 ec2

@nuttycom w.r.t. Proposal and associated structs, we need it to be serializable forwasm_bindgen so that we can pass it between JS and Wasm.

ec2 avatar Oct 11 '24 17:10 ec2

As per @daira 's suggestion, we will try using the protobuf encoding to do the passing back and forth.

ec2 avatar Oct 11 '24 17:10 ec2

I believe that the objectives of this PR were eventually satisfied by #1634

nuttycom avatar Aug 29 '25 02:08 nuttycom